search

JoeGruffins / cake_wallet

The open source repository for Cake Wallet, a noncustodial multi-currency wallet, and Monero.com, a noncustodial Monero-only wallet. Need help? Check out https://guides.cakewallet.com
https://cakewallet.com
MIT License
0 stars 2 forks source link

Add decred to macos/ios scripts and rescan page bug fix #13

Closed ukane-philemon closed 3 months ago

ukane-philemon commented 4 months ago

Builds on #12.

Tested on simnet: https://github.com/JoeGruffins/cake_wallet/issues/11#issuecomment-2227516005

Modified commits:

  1. https://github.com/JoeGruffins/cake_wallet/commit/ceef7e0f23689659fd96fc608c22e6e423b969c1
  2. https://github.com/JoeGruffins/cake_wallet/commit/97ad5c308c89d6aae5b0b555de93aef2e6d46f67
  3. https://github.com/JoeGruffins/cake_wallet/commit/f5305670a2a775a54534820e32283efd54abdf66
JoeGruffins commented 4 months ago

Is 7531942 for testing or do we need those changes?

ukane-philemon commented 4 months ago

Is 7531942 for testing or do we need those changes?

Errm, most of it was from @itswisdomagain commit on the stale branch. But we need the script and readme changes.

We would clean that commit of test changes once we are ready to push upstream.

ukane-philemon commented 3 months ago

@JoeGruffins you'll need to replace the upstream commit https://github.com/cake-tech/cake_wallet/pull/1322/commits/63357642a496e4a5658b35002c97ccd39c089653 with this one: https://github.com/JoeGruffins/cake_wallet/pull/13/commits/55d837ccc2a1a42083b95d7d9794e4e184a170ea, that is if there are no more required changes to make in that script commit.

Thanks.

JoeGruffins commented 3 months ago

Ok I updated it.

ukane-philemon commented 3 months ago

Thanks.

ukane-philemon commented 3 months ago

getting an error when building:

lib/entities/provider_types.dart:50:29: Error: A non-null value must be returned since the return type 'List<ProviderType>' doesn't allow null.
 - 'List' is from 'dart:core'.
 - 'ProviderType' is from 'package:cake_wallet/entities/provider_types.dart' ('lib/entities/provider_types.dart').
  static List<ProviderType> getAvailableBuyProviderTypes(WalletType walletType) {
                            ^
lib/entities/provider_types.dart:87:29: Error: A non-null value must be returned since the return type 'List<ProviderType>' doesn't allow null.
 - 'List' is from 'dart:core'.
 - 'ProviderType' is from 'package:cake_wallet/entities/provider_types.dart' ('lib/entities/provider_types.dart').
  static List<ProviderType> getAvailableSellProviderTypes(WalletType walletType) {

I think this comment was intended for #14, it has been resolved.

JoeGruffins commented 3 months ago

I think this comment was intended for https://github.com/JoeGruffins/cake_wallet/pull/14, it has been resolved.

Yeah sorry about that.

JoeGruffins commented 3 months ago

Changes have been added to the upstream pr so closing.