JoeKuan / Highcharts_Sencha

Highcharts extension for Sencha's ExtJS and Touch
Other
82 stars 44 forks source link

Highcharts_Ext5 column chart draws twice #34

Open Edvardoh opened 9 years ago

Edvardoh commented 9 years ago

I've tried to work around this issue by overriding the _onResize function in Chart/ux/Highcharts.js, and listening to the resize event on a parent Ext panel, however the draw method would still get called twice each time the window was resized and when the chart was first rendered.

I suspect it's something in the column serie file, since I see the issue in your examples as well, but only for the column charts.

Please let me know if you have any workarounds for this.

Really appreciate your work!

Edvardoh commented 9 years ago

Ok, so I was able to implement a fix, I will create a pull request for it shortly and you can bring it in if you like.

All I did was wrap the call to this.refresh() at the end of the draw() method with an Ext.defer(). The defer defaults to 0 milliseconds, and the user can pass in a config called drawDefer {integer}, which will delay the call to the refresh function.

For my issue with the column series, passing in 1000 milliseconds prevents the double draw I was experiencing very well.

Let me know of any concerns.

Edvardoh commented 9 years ago

Realized I don't have permission to push up a new branch in this repo (makes sense). If you'd like to grant me access I can push up my fix - if you don't like it you can always reject it.

Cheers

JoeKuan commented 9 years ago

Thank you very much for your contribution. I will try to sort out github later today and let you know.

Joe

On 14 May 2015 at 15:26, Ed Davis notifications@github.com wrote:

Realized I don't have permission to push up a new branch in this repo (makes sense). If you'd like to grant me access I can push up my fix - if you don't like it you can always reject it.

Cheers

— Reply to this email directly or view it on GitHub https://github.com/JoeKuan/Highcharts_Sencha/issues/34#issuecomment-102051834 .