Hi again. There seems to be an issue with the zones reported for Franco's driver with your sysfs enhancements. When using a factor that is not incremented by 1 as the multiplier for the calculation of threshold limits, KA assumes that the zones are in increments depicted by the thermal step value. Of course, with your defaults, this works fine as everything is incremented by 1, but I wanted something more dynamic so I utilized factors of 1,2,4,5,6,7, and 9 with a step value of 2. This should show a deviation of 2C,4C,8C,10C,12C,14C, and 18C, but instead in KA it is reported as being 2,4,6 etc... ahead of the base throttling value, so for instance, with my driver, the fourth step, third level, should be 46C, but it is reported in KA as only 44C. I could be wrong however though, and KA could be providing the right values, though I assume that I am right in my thinking. Here is a link to my heavily modified version of your Franco driver:
It features 8 throttling steps (though KA only displays 4 of them), and the ability to shut cores off one by one once the 4th step has been reached. It also uses VADC polling instead of TSENS too
Hi again. There seems to be an issue with the zones reported for Franco's driver with your sysfs enhancements. When using a factor that is not incremented by 1 as the multiplier for the calculation of threshold limits, KA assumes that the zones are in increments depicted by the thermal step value. Of course, with your defaults, this works fine as everything is incremented by 1, but I wanted something more dynamic so I utilized factors of 1,2,4,5,6,7, and 9 with a step value of 2. This should show a deviation of 2C,4C,8C,10C,12C,14C, and 18C, but instead in KA it is reported as being 2,4,6 etc... ahead of the base throttling value, so for instance, with my driver, the fourth step, third level, should be 46C, but it is reported in KA as only 44C. I could be wrong however though, and KA could be providing the right values, though I assume that I am right in my thinking. Here is a link to my heavily modified version of your Franco driver:
https://raw.githubusercontent.com/CertifiedBlyndGuy/ewok-onyx/Ewok/drivers/thermal/msm_thermal.c
It features 8 throttling steps (though KA only displays 4 of them), and the ability to shut cores off one by one once the 4th step has been reached. It also uses VADC polling instead of TSENS too