search

JoeStrout / minimicro-sysdisk

Contents of the /sys disk for the Mini Micro virtual computer
20 stars 11 forks source link

fatbits now uses FileDialog to open files #25

Closed BibleClinger closed 7 months ago

BibleClinger commented 7 months ago

Joe wrote on the MiniScript Discord:

Suddenly realized this week that /sys/demo/fatbits should be using the file browser (from /sys/lib/textUtil) to open an image, rather than asking the user to manually type in a path. This is probably a simple change, but I'm pretty swamped right now trying to catch up on things after my trip. Anybody want to bang that out and submit a PR (or just send me the revised script)?

As per this request, I changed /sys/demo/fatbits.ms to use FileDialog from textUtil.

I tested three cases:

  1. Cancel button is pressed. Nothing is done. :white_check_mark:
  2. Select button is pressed on a valid image. The image opens. :white_check_mark:
  3. Select button is pressed on an invalid image. The user is given the error message and nothing further is done. :white_check_mark:
JoeStrout commented 7 months ago

Great stuff, thank you!