search

JoeStrout / miniscript

source code of both C# and C++ implementations of the MiniScript scripting language
MIT License
282 stars 64 forks source link

Unknown file "QuickTest.mscp" #13

Closed Arcnor closed 5 years ago

Arcnor commented 5 years ago

Hi there,

First of all, I think it's very cool that you've open sourced MiniScript, it looks really nice, thanks for that!

I've tried running the tests (using Program.cs) and it looks like it's trying to load a file called "QuickTest.mscp" which is nowhere to be found.

Not sure if the file should be there, or that line should be removed, hence this issue.

Thanks!

JoeStrout commented 5 years ago

Ah, good catch — the C# main program will try to load and run this file. I use it to quickly test whatever I happen to be working on each day; that's why I didn't commit it to the archive. If I have a test I want to keep, I put it into TestSuite.txt (which is in the repo).

But the main program should certainly detect that QuickTest.mscp (so old is this file, it's from before I settled on ".ms" as a file extension!) is missing, and handle in gracefully. Feel free to make that change and issue a pull request! You could be our first, a badge of honor no one can ever take from you. :)

Arcnor commented 5 years ago

Good point, the honor shall be mine!

More seriously, maybe the right thing to do will be having that list of files to run as arguments? To remove those magic constants from the code itself, mainly.

I can open the PR just with the file detection, but it still feels like a hack 🙂.

On Mon, Aug 12, 2019, 03:37 JoeStrout notifications@github.com wrote:

Ah, good catch — the C# main program will try to load and run this file. I use it to quickly test whatever I happen to be working on each day; that's why I didn't commit it to the archive. If I have a test I want to keep, I put it into TestSuite.txt (which is in the repo).

But the main program should certainly detect that QuickTest.mscp (so old is this file, it's from before I settled on ".ms" as a file extension!) is missing, and handle in gracefully. Feel free to make that change and issue a pull request! You could be our first, a badge of honor no one can ever take from you. :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JoeStrout/miniscript/issues/13?email_source=notifications&email_token=AAAG7SFMGL3G5YQZMQB4SGLQEDEGPA5CNFSM4IK4TS42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BOYXA#issuecomment-520285276, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAG7SG7YKC64ZXMOQJLAY3QEDEGPANCNFSM4IK4TS4Q .