Is C++20 required in 1.6.2?

JoeStrout / miniscript

source code of both C# and C++ implementations of the MiniScript scripting language

MIT License

275 stars 64 forks source link

Is C++20 required in 1.6.2? #140

Closed toge closed 1 month ago

toge commented 6 months ago

I'm updating miniscript's Conan recipe.

I found miniscript/1.6.2 requires C++14. https://github.com/JoeStrout/miniscript/blob/master/CMakeLists.txt#L105-L107

But I found also some sources use C++20 features. https://github.com/JoeStrout/miniscript/blob/master/MiniScript-cpp/src/MiniScript/MiniscriptTypes.cpp#L18

Is C++20 required in 1.6.2?

JoeStrout commented 6 months ago

That requirement is not intended. If you want to try tweaking it to work with C++14, a PR will be gratefully appreciated. Or if that proves too difficult, then we'll upgrade the requirement — but let's discuss that here first.