JoeSz / Exopite-Simple-Options-Framework

Fast, easy and lightweight admin options/metabox form generator for WordPress Plugins and metaboxes.
GNU General Public License v3.0
78 stars 24 forks source link

Re-format code to follow Wordpress Coding Standards #4

Closed raoabid closed 6 years ago

raoabid commented 6 years ago

Hey Joe,

Thanks Brother for the merge, This request only tries to reformat the code to follow Wordpress Coding Standard. No line of code is changed.

JoeSz commented 6 years ago

I see your point, you using tabs instead of spaces. "Your indentation should always reflect logical structure. Use real tabs and not spaces, as this allows the most flexibility across clients." I like spaces better and my editor is convert tabs to spaces automatically, but if you or someone want to use this framewrok in a plugin or themes which publist by WordPress, must follow coding standars. Or should be, I saw some plugins sources :) But yes I see your point, I think about a little.

raoabid commented 6 years ago

I am using phpStorm IDE and have also configured to auto format the code using Wordpress Coding Standards. It also have phpcs integrated so that the plugins i write follow the phpcs standards along with Wordpress Coding standards. All this re-formatting of code is done auto. Stay tuned for more pull requests! ;)

JoeSz commented 6 years ago

I will merge, but you should know, I already almost finised with multilang compatibility (WPML, Multilang and qTranslate X) and new option for post meta (save post meta array or not in array, this is sometime required for meta querys) and there I use spaces, I do my best, but I may override some of this files with the "old" spaced" version.

raoabid commented 6 years ago

No problem in that, once you are done with code editing, i shall initiate a new pull request fixing only the WP coding standards issues.

Thanks for the merge

JoeSz commented 6 years ago

Well, thank YOU for your work and contribution!