search

Joedmin / xExtension-wallabag-button

Add FreshRSS articles to Wallabag with one simple button click or a keyboard shortcut.
MIT License
6 stars 2 forks source link

Add PHPStan #1

Closed Alkarex closed 1 month ago

Alkarex commented 1 month ago

Up to PHPStan level 6, but you should increase it to 9 https://phpstan.org/user-guide/rule-levels Fixed many obsolete FreshRSS calls.

Alkarex commented 1 month ago

You should have the FreshRSS folder alongside your extension folder, and tell your editor tools about its path.

For instance, for the Intelephense extension for PHP in VSCode, you can set the following in your .vscode/settings.json:

{
    "intelephense.environment.includePaths": [
        "../FreshRSS/"
    ]
}
Joedmin commented 1 month ago

Thank you very much for this PR! I'll make sure to fix the issues you mentioned so my extention can be up-to-date 😁

Joedmin commented 1 month ago

May I please ask you @Alkarex for one more help? 🙏 I'm currently rewriting a part of readeck extension and I have an issue with the $view property in the Controller.

See

How can I fix this issue please?

Alkarex commented 1 month ago

You were lacking the View class. See https://github.com/Joedmin/xExtension-readeck-button/pull/6

Joedmin commented 1 month ago

Oh I see! Thank you very much!