search

JoelBender / bacpypes

BACpypes provides a BACnet application layer and network layer written in Python for daemons, scripting, and graphical interfaces.
MIT License
302 stars 129 forks source link

PulseConverterCriteria renew covPeriod #431

Closed bobreim closed 3 years ago

bobreim commented 3 years ago

An error occurs when I'm changing the covPeriod for objects with a PulseConverterCriteria:

File ".../lib/python3.7/site-packages/bacpypes/service/cov.py", line 459, in cov_period_filter
    self.cov_period_task = RecurringFunctionTask(new_value * 1000, self.cov_period_x)
AttributeError: 'PulseConverterCriteria' object has no attribute 'cov_period_x'

cov_period_x does not exist. Shouldn't this be self.send_cov_notifications?

JoelBender commented 3 years ago

Apparently the commit message I provided closed this issue, but thank you for the bug report.

bobreim commented 3 years ago

All right! Thank you for the fast fix.