search

JoelCourtney / mdbook-kroki-preprocessor

Render Kroki diagrams from files or code blocks in mdbook
GNU General Public License v3.0
11 stars 7 forks source link

Link openssl statically? #34

Closed dilawar closed 3 months ago

dilawar commented 3 months ago

Bug description

Not really a bug in the tool but a minor inconvenient when using the already built binary on Linux. Binary dynamically links with a version of SSL that may not be present on the system.

To Reproduce

Steps to reproduce the behavior:

  1. Install the tool using cargo-binstall. cargo binstall -y mdbook-kriki-processor on a recent linux.
  2. Run the tool.
  3. mdbook-kroki-preprocessor: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

cargo install mdbook-kroki-pocessor work as expected since the binary is built locally.

Expected behavior

Binary on linux should work without relying on right version of libssl.

Screenshots

Environment

Additional context

Thanks for the tool. Its great. Happy to send a PR that will link with openssl statically but increase the binary size.

dilawar commented 3 months ago

Ah, sorry. I just noticed that the binary was installed by cargo-binstall from a third party source QuickInstall and this repo release section has no binaries attached. 

Press ENTER or type command to continue                                                                         
 WARN Failed to retrieve token from `gh auth token` err=Os { code: 2, kind: NotFound, message: "No such file or 
directory" }                                                                                                    
 WARN Failed to read git credential file                                                                        
 INFO resolve: Resolving package: 'mdbook-kroki-preprocessor'                                                   
 WARN Your GitHub API token (if any) has reached its rate limit and cannot be used again until Instant { tv_sec:
 1722743170, tv_nsec: 887540988 }, so we will fallback to HEAD/GET on the url.                                  
 WARN If you did not supply a github token, consider doing so: GitHub limits unauthorized users to 60 requests p
er hour per origin IP address.                                                                                  
 WARN The package mdbook-kroki-preprocessor v0.2.0 (x86_64-unknown-linux-gnu) has been downloaded from third-par
ty source QuickInstall                                                                                          
 INFO This will install the following binaries:                                                                 
 INFO   - mdbook-kroki-preprocessor (mdbook-kroki-preprocessor -> /home/dilawar/.cargo/bin/mdbook-kroki-preproce
ssor)                                                                                                           
Do you wish to continue? yes/[no]