search

JoelGodOfwar / MoreMobHeads

A port of More Mob Heads datapack.
MIT License
5 stars 7 forks source link

Please fix the code [explanation in content] #4

Closed Prof-Bloodstone closed 3 years ago

Prof-Bloodstone commented 4 years ago

There's so many things wrong.

Why are you doing network requests on main thread? Why do you do them for each player join - even if the check is disabled and player is not op?

Why do you need to know the version of plugin on my server and my seed?

I'd love to use this plugin - but it is a big performance and potentially security issue rn, and I'd prefer not to rewrite it myself.

JoelGodOfwar commented 4 years ago

Which version of the plugin are you using? Since 1.14_1.0.9 MMH only checks for updates on the enable, and notifies players with permission moremobheads.showUpdateAvailable which is default OP. The plugin does not check for updates if auto_update_check is false. Nothing in MMH checks your seed, or the version of any other plugin, in any version of the plugin.

Feel free to join my discord server https://discord.gg/Bh5YDRC if you'd like to present proof of any issues.