search

JoelHT-Landmark / NuGet-PackageNPublish

Project template and packaging targets file to allow easier Package'n'Publish integration with TFS (or other CI) builds.
Other
13 stars 12 forks source link

TextTransform.exe not found when using Visual Studio 2017 #35

Open dkorzhin opened 6 years ago

dkorzhin commented 6 years ago

It looks like TextTransform.exe location is not handled when only Visual Studio 2017 is installed.

I had to change LocateTTGenExe in NuGet.PackageNPublish.targets to be able to compile the project adding the following line: <TTGenPath>$(DevEnvDir)\$(TTGenExe)</TTGenPath>

Please check if the same can be solved using TTGenLocation.Identity.

So the Target block looks like this:

<Target Name="LocateTTGenExe"> <ItemGroup> <TTGenPaths Include="@(VSVersion)"> <Path>%(TTGenLocation.Identity)</Path> </TTGenPaths> </ItemGroup> <PropertyGroup> <TTGenPath>$(DevEnvDir)\$(TTGenExe)</TTGenPath> <TTGenPath Condition="($(TTGenPath) == '' Or $(TTGenPath) == 'Undefined') And (Exists('%(TTGenPaths.Path)\%(TTGenPaths.Identity)\$(TTGenExe)'))">%(TTGenPaths.Path)\%(TTGenPaths.Identity)\$(TTGenExe)</TTGenPath> </PropertyGroup> <Message Text="$(TTGenExe) was found at $(TTGenPath)" Importance="high" /> </Target>

Thanks

JoelHT-Landmark commented 6 years ago

That's odd - I've been using the latest (0.10.1.3) practically daily at work, and I've never installed anything other than VS2017. In fact the 0.10.1.3 release was all about VS2017 support.

Can you create a new empty Net 462 class library, add PnP and build with logging set to Debug- that's the basic fitness test I use for PnP

I deliberately didn't use $(DevEnvDir) because PnP needs to work on build servers that have the .Net SDK installed, but not necessarily VS2017. But feel free to fork the repo and give me a PR to look at.

Joel

dkorzhin commented 6 years ago

Hi Joel, This is the error I am getting:     Unable to locate 'TextTransform.exe' - install a VS-SDK or build with /p:RegenerateNuSpecFiles=false

The only place where I found TextTransform.exe is:        C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE

Even after installing VS SDK (part of VS 2017 Enterprise Install) and .Net 4.5.2 Dev Pack that is the only location.

Maybe it's the case with VS 2017 Enterprise only? Wonder what else needs to be installed on Jenkins if we need VS 2017 to be installed as well - to have your package working?

We still use Nuget.PackageNPublish 8.0.2 with Visual Studio 2012 and looking to upgrade. Thanks,Dmitriy

On Monday, November 5, 2018, 5:30:09 AM EST, Joel Hammond-Turner <notifications@github.com> wrote:

That's odd - I've been using the latest (0.10.1.3) practically daily at work, and I've never installed anything other than VS2017. In fact the 0.10.1.3 release was all about VS2017 support.

Can you create a new empty Net 462 class library, add PnP and build with logging set to Debug- that's the basic fitness test I use for PnP

I deliberately didn't use $(DevEnvDir) because PnP needs to work on build servers that have the .Net SDK installed, but not necessarily VS2017. But feel free to fork the repo and give me a PR to look at.

Joel

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.