Should PyPI upload logic run on master branch?

JoelLefkowitz / drf-yasg

Automated generation of real Swagger/OpenAPI 2.0 schemas from Django REST Framework code.

https://drf-yasg2.readthedocs.io/en/stable/

BSD 3-Clause "New" or "Revised" License

65 stars 2 forks source link

Should PyPI upload logic run on master branch? #38

Closed johnthagen closed 4 years ago

johnthagen commented 4 years ago

https://travis-ci.com/github/JoelLefkowitz/drf-yasg/jobs/398272466

It seems like the upload commands should only get run for tags or when manually specified. I could be missing something about the purpose of this running in master though.

JoelLefkowitz commented 4 years ago

It's to prevent publishing a commit that got pushed to branch that had local tags that got pushed. I'll remove it for 1.19 for simplicity

JoelLefkowitz commented 4 years ago

This is now implemented in 1.19 release