search

JoelOtter / kajero

Interactive JavaScript notebooks with clever graphing
Other
1.87k stars 110 forks source link

Inline HTML is not rendered #34

Closed ofirgeller closed 8 years ago

JoelOtter commented 8 years ago

Don't transform inline HTML.

Changed the title to what I think you meant as it was a little confusing.

I'm aware of this - currently trying to work out what the desired behaviour is. It'll be an easy change. If other people want this, give a +1 to the above comment.

ofirgeller commented 8 years ago

The arguments for not transforming html are:

  1. Adds power. there will always be a limit to what you can do with MD. and you as a developer can never fill all the needs others may have.
  2. At least this implementation of MD is in favor of allowing inline HTML.
  3. why would anyone include html in MD outside of a code block if not to be rendered as HTML?
JoelOtter commented 8 years ago

Yes, I think you're right. HTML elements would also allow inline styling, which may be useful to some users (e.g. for setting the size or alignment of images).

I'll run a few tests and if everything seems ok I'll flip the switch.

JoelOtter commented 8 years ago

Should be working now. Here's a notebook with a super-stretched photo of Mr Rogers.

http://www.joelotter.com/kajero/?id=6af6cbb36a8f801be39d3bc8ec04e8ed

ofirgeller commented 8 years ago

thanks!