search

JoelOtter / kajero

Interactive JavaScript notebooks with clever graphing
Other
1.87k stars 110 forks source link

Add jQuery to code blocks #59

Closed tpetrina closed 7 years ago

tpetrina commented 7 years ago

Hi,

I know you already are tracking #43 and #39, but I feel jQuery is a must have library in every notebook demonstrating UI. If you think jQuery should be optional, maybe there should be a configuration check per notebook toggling on/off jQuery and some other libraries.

I am willing to discuss alternative implementations to this. Since I don't want to maintain fork of Kajero, pull request tries to remedy that :)

Also, love the project!

Cheers Toni

JoelOtter commented 7 years ago

Hi,

We currently have an issue open (ignore the conversation, it got hijacked) to track adding arbitrary third-party libraries to notebooks. I'm strongly against adding jQuery by default, because it's huge and also I hate it.

I do think supporting third-party libraries is pretty much a must-have, I just haven't really had time to get to this yet.

If you really really want jQuery right now I'd advise just adding it on the window by adding a <script> tag inside your document's <head>.

Cheers!

tpetrina commented 7 years ago

No problem, thanks for the feedback.