search

JoelOtter / termloop

Terminal-based game engine for Go, built on top of Termbox
Other
1.43k stars 83 forks source link

Two small changes #26

Closed jodizzle closed 8 years ago

jodizzle commented 8 years ago
  1. In the comments of #23 @leavengood picked up on the non-necessary break statements inside Go switch blocks. I had noticed this a while back and went ahead and removed them from the repository (hopefully this isn't too presumptuous).
  2. The old link for the portaudio Go bindings package died with Google Code, and it now redirects to a Github page, so the relevant import statement in audio.go needs to be changed.
JoelOtter commented 8 years ago

I think this looks good. Is there no 'official' GitHub repo for portaudio-go, though? Or is that project generally not maintained any more?

leavengood commented 8 years ago

The google code URL redirects to that GitHub project, so that must be as "official" as it gets.

jodizzle commented 8 years ago

Yes I believe @leavengood is accurate. The GitHub repository seems to be the official one.

As a side note, I've been unable to get audio.go to work properly on my system (unrelated to my changes in this PR). The issue seems to stem from gosndfile being unable to use certain C-imported methods, e.g.,

/home/path/go/pkg/gccgo_linux_amd64/github.com/mkb218/gosndfile/libsndfile.a(command.cgo2.o): In function `_cgo_fb0d5eb9e69c_Cfunc_sf_command':
/home/path/go/src/github.com/mkb218/gosndfile/sndfile/command.go:34: undefined reference to `sf_command'

even though I have libsndfile installed and (I'm pretty sure) my path configured correctly. If anyone has run into any similar issues, I'd appreciate advice (I may eventually just open an issue directly with gosndfile).

JoelOtter commented 8 years ago

Sorry for the delay - this looks good to me.

Portaudio is still working on my system with the new library.