JoelSjogren / most

More subtitles for Viki.com (unofficial)
MIT License
4 stars 0 forks source link

Fullscreen on mac and color #2

Open aybukeince opened 3 months ago

aybukeince commented 3 months ago

Hello, I am using mac so F11 does not work for me to get fullscreen. When I use Control+Command+F to get fullscreen, I lose the subtitles. Is there a way I can use this on fullscreen on mac? Also when I turn this on (not on fullscreen) I think the screen gets darker/less saturated. Is it fixable? Thank you.

Edit: I found a way for fullscreen, interestingly if I use shift+command+f to go fullscreen I get it without subtitles again but then when I press esc I get the subtitles. The color problem, however, persists.

Edit 2: I realised when one subtitle is at the top and the other one is at the bottom, it is as if the whole screen is the background of the subtitles, hence a lot darker. I solved this by putting both titles at the bottom, now only the bottom part of the screen is dark. I would prefer to put one on top but I do not know if the code is modifiable to not darken the place between the subtitles.

JoelSjogren commented 3 months ago

Hello Aybüke, it's good that you found the workaround described in your first edit, because I have generally no idea about mac stuff (although in retrospect I would conclude that shift-command-f makes both (1) the browser window take up the whole screen space and (2) the video take up the whole browser window in some strict sense, and that pressing esc reverts (2) to only holding in a weak sense. The problem analysis described in the second edit also seems to me the correct one. Does this happen with the default settings (in the extension's subtitle preview page)?