Refactored all class names to the short name version without "chart".

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.

Other

40 stars 6 forks source link

Refactored all class names to the short name version without "chart". #61

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

Fixes https://github.com/Joelius300/ChartJSBlazor/issues/28.

I have adjusted:

ChartAxis to Axis
ChartConfig to Config
ChartData to Data
ChartOptions to Options
ChartDataset to Dataset
ChartPoint to Point
ChartScales to Scales

I cannot test if there are some errors because this branch doesn't have https://github.com/Joelius300/ChartJSBlazor/pull/60 included yet (I can't run it on preview8 yet).

There still are the following errors:

These are already fixed in https://github.com/Joelius300/ChartJSBlazor/pull/60, so merge https://github.com/Joelius300/ChartJSBlazor/pull/60 first and then this one @Joelius300, please.

Joelius300 commented 5 years ago

Very good job.

I have resolved the conflicts with the updated master branch and checked if everything still works.
I also went through all the changes and didn't see any mistakes. Since there are so many changes I really hope I didn't miss anything.

Btw great job doing the conventions as well, would've probably forgotten about that :)

Ps. Looking through all these classes is horrible because you see soo many errors and inconsistencies, damn. We really need to get through these charts :/

First we need IndexableOptions though.

SeppPenner commented 5 years ago

Btw great job doing the conventions as well, would've probably forgotten about that :)

I have searched for the terms I listed above and adjusted every occurence ;D I really like VS Code when searching for things in files.

Ps. Looking through all these classes is horrible because you see soo many errors and inconsistencies, damn. We really need to get through these charts :/

I know. I already wanted to change things but didn't do it because it wasn't the purpose of this pull request.

Joelius300 commented 5 years ago

I know. I already wanted to change things but didn't do it because it wasn't the purpose of this pull request.

Very good :) We'll do these one by one otherwise it's just too much chaos. But yea.. there are issues :(