search

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.
Other
40 stars 6 forks source link

Small fixes in readme, example code update. #82

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

I updated the readme a bit. I'm not sure if we should use the weather forecast example here as well? What do you think @Joelius300?

Joelius300 commented 5 years ago

Good catch with the PieOptions constructor, that was a no-brainer of me.

No, I don't think we should use the weather forecast example here. We want the example to be as simple as possible and, most importantly, independent. If the first example the consumers see is one they can't just copy-paste, it makes following the readme/documentation a lot less intuitive.

I will close this PR now since I only want the small change at the top of the readme (Line 39/40) and this PR just contains a lot more than that. Also for something this small I don't want more than one commit (which would be exeeded if we use this PR for that).