Enum class names should be consistently singular

Joelius300 / ChartJSBlazor

This library is a modification of the awesome ChartJs.Blazor library by mariusmuntean. It's supposed to add more functionality to the LineChart and generally make the library more complete.

Other

40 stars 6 forks source link

Enum class names should be consistently singular #85

Closed SeppPenner closed 5 years ago

SeppPenner commented 5 years ago

Currently, we have the following:

Should enum class names be singular or plural? (There is just one (ChartTypes) that is plural) at the moment. (PointStyles is the one I'm currently working on).

Joelius300 commented 5 years ago

It should be singular. You can rename ChartTypes to ChartType, it shouldn't have any consequences outside of the library as far as I'm concerned. PointStyles is new so you can rename it without consequences.

You missed two more though:

Positions should be renamed to Position.
ScaleBounds should be renamed to ScaleBound since bound does make sense here even though it kind of sounds wrong in my foreign ears :)

SeppPenner commented 5 years ago

I already thought that there were some more and I only didn't see them in the screenshot.

PointStyles is already renamed, I will do the others within the special enum branch.

SeppPenner commented 5 years ago

Is fixed in https://github.com/Joelius300/ChartJSBlazor/issues/87.

SeppPenner commented 5 years ago

I guess this can be closed as well.