search

Joellimjr / pe

0 stars 0 forks source link

Corrupt save file causes crash #10

Open Joellimjr opened 5 months ago

Joellimjr commented 5 months ago

image.png

image.png

If the save file is edited and there is a typo, the program crashes

nus-se-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Exception not handled after editing file

image.png

image.png

After editing file for habits into an invalid format, program crashes instead of handling the exception gracefully.

[original: nus-cs2113-AY2324S2/pe-interim#2557] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As mentioned in the user guide, editing the text file directly is not recommended as the behavior of the application might become unpredictable. Users are recommended to only interact with the storage text files via commands only on the CLI.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The project requirements state that advanced users should be allowed to edit the save files for greater efficiency. Granted that the number of advanced users is smaller but the inability of the program to handle corrupt save files might affect their use of the app.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** The number of advanced users who will edit the save file might be small. However, there is still the chance that new users might accidentally edit something in the file or that a file might not have been saved properly. This would cause the user to be completely unable to load up the app and if they are new users, they might not be able to diagnose the problem and thus be unable to use the app. This issue could affect many more people that just the advanced users.