search

Joellimjr / pe

0 stars 0 forks source link

Adding sleep cycle on invalid date that is 31 and below #5

Open Joellimjr opened 3 months ago

Joellimjr commented 3 months ago

image.png

image.png

Adding a sleep cycle on a day that does not exist does not throw an error but instead adds a sleep cycle on the last valid date

soc-se-bot commented 3 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Entered in invalid date but was still added into sleep list

image.png

Entered 31/02/2000 into command line, expected error message but it added 29/02/2000 into sleep list

[original: nus-cs2113-AY2324S2/pe-interim#2554] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted that this is of medium severity, but this is a feature flaw, as instead of adding the hours to an invalid sleep cycle, we have assigned it to a nearer date, if the day is between 1-31.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]