search

JoepVanlier / Hackey-Patterns

A LUA sequencer plugin for REAPER 5.x and up. Designed to mimick the pattern editor in Jeskola Buzz.
MIT License
9 stars 0 forks source link

When adding a new pattern in sequencer, sometimes it adds it (the number 01) one line above #5

Closed michaelsjackson closed 6 years ago

michaelsjackson commented 6 years ago

This happens usually at lower positions. I am sure you would find the error causing position in code much faster. Only the position in the sequencer grid is wrong, the placement in arrange seems to be correct.

Example: Placing a 1 bar pattern in sequencer at position/line 0 adds 4 lines, which is correct. ..., at position 64 adds 4 lines, which is correct. ..., at position 128 adds 5 lines, which is one line too much. Maybe this example helps a little.

Strangely ..., at position 672 adds 4 lines, which is correct, again.

Now zero is zero is great, and not one.

Tracks getting default track names in sequencer is great. (Track 00, Track 01...)

Double click opened hackey trackey great. ENTER doing this would be perfect. Same for switching back using ENTER.

JoepVanlier commented 6 years ago

I cannot reproduce this on my end. Can you send me an example file that does this? I suspect that it is a round-off error somewhere in the pipeline. I could reduce item length by a little epsilon to prevent this, but I'd need a file that has this problem.

michaelsjackson commented 6 years ago

Well, I am using Reaper 32 bit, in wine, in ubuntu 64bit.

JoepVanlier commented 6 years ago

Can you attach an RPP file where this happens?

michaelsjackson commented 6 years ago

Of course.

hackey_patterns_016.RPP.zip

It seems almost in all cases, the placement on the excel table is one line above, all ending up in 5 lines, instead of correct 4 lines.

michaelsjackson commented 6 years ago

I guess, the error could have some relationship to page scrolling, so after you have scrolled down the view, below max line, then back up, the grid counting is not correct any more, thus placements occur on different positions. Maybe this helps a little.

michaelsjackson commented 6 years ago

I could even make a video / youtube, if it helps, how it looks here.

michaelsjackson commented 6 years ago

I really love this yellow line already, the current playing position. .-)

JoepVanlier commented 6 years ago

Thanks for the RPP file. I see what you mean now. Fixed in 9761f73d1201d7dbc9cc80f6fa139c2c2346c8ae