JoepVanlier / Hackey-Trackey

A LUA tracker plugin for REAPER 5.x and up. Designed to mimick the pattern editor in Jeskola Buzz.
MIT License
130 stars 10 forks source link

Add a couple of commands and improve shift + note behaviour #72

Closed jmckernon closed 4 years ago

jmckernon commented 4 years ago

Details to follow in the Hackey Trackey forum thread (https://forum.cockos.com/showthread.php?t=202382).

JoepVanlier commented 4 years ago

This slipped my mind earlier, but one minor thing that may be worth considering. Could be nice to make the new functionality optional. Could do this via:

Under "-- Default configuration" add tracker.cfg.switchback = 1

Under "tracker.binaryOptions =" add { 'switchback', 'Go back to first column when entering chords' },

And then change if tracker.shiftChordInProgress and gfx.mouse_cap & 8 == 0 then to if tracker.cfg.switchback == 1 and tracker.shiftChordInProgress and gfx.mouse_cap & 8 == 0 then

Then it just becomes a toggle-able option in the options screen.

jmckernon commented 4 years ago

I agree that all the extra if statements are a bit nasty. I have an idea for a nicer way to do it, inspired by your suggestion but slightly different. I'll write it up in a bit and you can see whether you prefer it. If you don't like it then I'll implement your suggestion as described.

Happy to add it as an option, though I think it makes sense for it to be on by default. (I would be surprised if anyone preferred the old behaviour.)

JoepVanlier commented 4 years ago

Looks good to go! :+1:

Thanks!