JoepVanlier / Hackey-Trackey

A LUA tracker plugin for REAPER 5.x and up. Designed to mimick the pattern editor in Jeskola Buzz.
MIT License
131 stars 10 forks source link

add note names panel #73

Closed jmckernon closed 4 years ago

jmckernon commented 4 years ago

I added a new panel which may be useful for those tracking drum patterns: one which displays the names assigned to the midi notes of the current channel. (These are set I think by reasamplomatic5000, certainly by rs5k manager.) I assigned it to F10 in the default keymap.

Other things I changed in passing:

Haven't tested it very thoroughly yet but so far it seems to hold up ok. Let me know your thoughts.

Thanks!

JoepVanlier commented 4 years ago

Neat! It seems that switching track doesn't update the note names. When I make one track with a reasamplomatic, I do see the names. But when I toggle track with CTRL + SHIFT + left/right, I don't see them disappear when I go on a track that has no note names or a track that has different note names.

Easiest way to fix this is to call getNoteNames in tracker:setTake instead of when the window is created. This makes it update every time.

JoepVanlier commented 4 years ago

One last minor comment by the way. There's another version number on line 362. Might wanna keep that one updated as well :)

Thanks for all the new goodies! :)

jmckernon commented 4 years ago

Good feedback, thx. Will make those changes and then toss it back to you for another look.

jmckernon commented 4 years ago

Ready to go as far as I'm concerned.

JoepVanlier commented 4 years ago

Awesome. Available to everyone now.

Thanks for the contrib! :)

jmckernon commented 4 years ago

My pleasure!