JoepVanlier / JSFX

A bundle of JSFX and scripts for reaper.
MIT License
417 stars 17 forks source link

Octave Mode Midi Fix #107

Closed camerongillette closed 8 months ago

camerongillette commented 8 months ago

Hey there, I love your work, thank you so much. I found a tiny bug and here's the code to fix it.

On the final boss plugin, line 33 needs to be updated because as is, it can't select the different octave modes.

slider14:octaver_mode=0<0,5,1>-Octave mode

I tried to make a pr, but I would need write permissions. Anyway, hope this was helpful, thank you again for your amazing work.

-BABYWOLF

JoepVanlier commented 8 months ago

Hey there, I love your work, thank you so much. I found a tiny bug and here's the code to fix it.

On the final boss plugin, line 33 needs to be updated because as is, it can't select the different octave modes.

slider14:octaver_mode=0<0,5,1>-Octave mode

Good catch! Merged in version 0.09.

I tried to make a pr, but I would need write permissions.

Ah yeah, that's pretty typical. For future reference, normally the workflow is to make a fork, make the changes there and then you can do a pull request upstream. This works too though and in some cases is faster! For a fix like this, this is perfectly fine.

Anyway, hope this was helpful, thank you again for your amazing work.

It is! Thanks for contributing!