JoepVanlier / JSFX

A bundle of JSFX and scripts for reaper.
MIT License
389 stars 19 forks source link

Not OTT - Dry/Wet volume is not linear #19

Closed andivax closed 3 years ago

andivax commented 3 years ago

Hi! Dry/wet volume has not linear behaviour. in 50% it is louder than dry or wet signal.

JoepVanlier commented 3 years ago

I've been doubting how to best handle the dry/wet controls.

How the controls work now is: Left = 100% dry. Right = 100% wet. Center = 100% dry + 100% wet. So your observation is indeed correct.

The curves are linear in signal amplitude.

It would be easy to add options for different dry/wet laws. Which one do you have in mind? Just simultaneous linear 1 to 0, 0 to 1 for wet/dry?

andivax commented 3 years ago

Thank you for the clarification! Your controls setup is very rare. I have seen this only in one fx processor

BTW I am beta tester for PSP and Relab. So feel free if you will need testing or help with your plugins!

Thank you!

Сб, 21 авг. 2021 г. в 15:41, Joep Vanlier @.***>:

I've been doubting how to best handle the dry/wet controls.

How the controls work now is: Left = 100% dry. Right = 100% wet. Center = 100% dry + 100% wet. So your observation is indeed correct.

The curves are linear in signal amplitude.

It would be easy to add options for different dry/wet laws. Which one do you have in mind? Just simultaneous linear 1 to 0, 0 to 1 for wet/dry?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JoepVanlier/JSFX/issues/19#issuecomment-903111088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLSQUMK2ESGYWFVGXI376DT56NI5ANCNFSM5CQIWY7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- www.ANDIVAXMASTERING.com

JoepVanlier commented 3 years ago

Yeah, it's a good point. I've switched back to the more classical dry/wet control as the default.

Note that old presets will still use the legacy mode (which can now be selected under the advanced menu).

andivax commented 3 years ago

Thank you! It is more predictable behaviour of dry/wet. People will definitely love it )

Вс, 22 авг. 2021 г. в 00:34, Joep Vanlier @.***>:

Yeah, it's a good point. I've switched back to the more classical dry/wet control as the default.

Note that old presets will still use the legacy mode (which can now be selected under the advanced menu).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JoepVanlier/JSFX/issues/19#issuecomment-903179076, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLSQULGABJGF7BDTMBIWT3T6ALWFANCNFSM5CQIWY7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- www.ANDIVAXMASTERING.com

JoepVanlier commented 3 years ago

I wonder if dry/wet is actually a bit of a misnomer.

The dry signal in this case is still run through the filters (to make sure the phase stays coherent with the wet signal when using the non-FIR option). Because if you don't, you of course get a lot of spurious cancellation.

Technically, that isn't dry. So maybe I should switch to "amount" here or something.

andivax commented 3 years ago

neh nobody cares what's under the hood )

пн, 23 авг. 2021 г. в 17:29, Joep Vanlier @.***>:

I wonder if dry/wet is actually a bit of a misnomer.

The dry signal in this case is still run through the filters (to make sure the phase stays coherent with the wet signal when using the non-FIR option).

Technically, that isn't dry. So maybe I should switch to "amount" here or something.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JoepVanlier/JSFX/issues/19#issuecomment-903826982, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARLSQUOABAJJDKJ2BDN3GLDT6JLNVANCNFSM5CQIWY7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

--

http://www.andivaxmastering.com/

Andrii "ANDI VAX" Vakhnenko

www.ANDIVAXMASTERING.com http://www.andivaxmastering.com/

[image: Facebook] https://www.facebook.com/groups/207215009301681/ [image: Youtube] https://www.youtube.com/user/andivax

JoepVanlier commented 3 years ago

Fair point! :)

I'll close this one then as fixed in https://github.com/JoepVanlier/JSFX/commit/6dc8e42ad4e8c30309ed0b44501a967ce359d0a4 :)