search

JoepVanlier / JSFX

A bundle of JSFX and scripts for reaper.
MIT License
375 stars 19 forks source link

MIDI Arp: Pattern doesn't reset on incoming MIDI notes #86

Closed samlletas closed 1 year ago

samlletas commented 1 year ago

When selecting MIDI mode the pattern doesn't reset on incoming MIDI notes, it instead seems to behave like the Free mode where the pattern keeps continuously running and resets on playback.

Additionally, when closing and opening projects the mode always changes back to Host.

MIDI Arp v0.32 Reaper v6.81

JoepVanlier commented 1 year ago

Thanks for the report! Fixed in v0.33!

samlletas commented 1 year ago

Thanks for taking a look at this!

However I was not able to try the new version because ReaPack shows a 404 error when trying to update, I looked at the index file and the commit ID seems to point to a non existent commit: https://github.com/JoepVanlier/JSFX/commit/5989519d5e13880fe49fa56b6b34dd7147376a9d

Shouldn't that be https://github.com/JoepVanlier/JSFX/commit/767c93e4000752fac23a98c9abdb3001f97050ad instead?

JoepVanlier commented 1 year ago

It most certainly should. Sorry 'bout that. I must have run the indexer before I merged (I quickly amended the commit, should work now hopefully 😅).

samlletas commented 1 year ago

Tried updating but still gives 404 errors 😅, looks like the 3 jsfx-inc files listed in v0.33 are still pointing to the non-existent https://github.com/JoepVanlier/JSFX/commit/5989519d5e13880fe49fa56b6b34dd7147376a9d commit:

https://github.com/JoepVanlier/JSFX/blob/ec6bb9330491491b561daf2b43d627d83df2dde5/index.xml#L5593 https://github.com/JoepVanlier/JSFX/blob/ec6bb9330491491b561daf2b43d627d83df2dde5/index.xml#L5594 https://github.com/JoepVanlier/JSFX/blob/ec6bb9330491491b561daf2b43d627d83df2dde5/index.xml#L5595

JoepVanlier commented 1 year ago

I ended up just bumping the version number, treating v0.33 as a botched release. I didn't want to rewrite history, since I pushed a few things after. Hopefully v0.34 works.

samlletas commented 1 year ago

v0.34 works perfectly, can confirm MIDI mode issue is fixed and selected mode is restored when reopening projects, thank you very much!

JoepVanlier commented 1 year ago

Cool! Thank you for the bug report and testing!

Closing the issue for now. Please don't hesitate to open another one if you run into further issues.