search

JoepVanlier / JSFX

A bundle of JSFX and scripts for reaper.
MIT License
396 stars 18 forks source link

midi_arp: fix polyphony button min/max values #91

Closed samlletas closed 1 year ago

samlletas commented 1 year ago

The polyphony button is clamped to min=2 and max=6, however polyphony can actually be automated and be set to values between 1 and 12 (also MAX_POLYPHONY constant seems to be set to 12), this PR fixes the button ranges so that we can create patterns with more than 6 notes without working around it via polyphony automation.

samlletas commented 1 year ago

Thanks! Should I version bump this one too?

JoepVanlier commented 1 year ago

Thanks! Should I version bump this one too?

Yes please. Rebase this branch to master (I just merged your other PR) and bump it one more (that should put it at 0.36). Once this one is merged I'll push the release and then your fixes will be out in the wild.

samlletas commented 1 year ago

All right, I messed up the rebase the first time but hopefully it's fixed now, also bumped to version 0.36 👍

JoepVanlier commented 1 year ago

Yep. Merged it, thank you! :)

Edit: And they're released!

samlletas commented 1 year ago

Nice, thank you!