search

JoepVanlier / ysfx

Hosting library for JSFX
Apache License 2.0
37 stars 3 forks source link

[BUG] All keys not working in Sequencer Megababy JS scripts #55

Closed sollapse closed 1 month ago

sollapse commented 1 month ago

The sequencer megababy series of plugins do not work with the Ctrl key modifiers (tested in Ardour). Shift seems to work well.

To Reproduce Steps to reproduce the behavior: Load any of the sequencer megababy JS scripts, attempt to adjust the velocity of a note using the Ctrl+Left mouse drag.

Expected behavior The velocity of the note should be altered.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): Windows 11

JoepVanlier commented 1 month ago

Confirmed. Shouldn't be too hard to fix. Will report back when I tested the modifiers work correctly on all three platforms.

JoepVanlier commented 1 month ago

I opened a PR to fix this here. Could you try the following and see if it works as intended? I'll wait with merging until you confirm that it works as intended.

Windows 64-bit VST3.zip

Do note that I do not yet support the windows key.

sollapse commented 1 month ago

It working as expected now. Thanks for the fix!

JoepVanlier commented 1 month ago

Great! I'll go ahead and merge it then! Thanks for the bug report and for reporting back!