macOS support is good

[hyperknot]

As of today, I've just cloned and built this on macOS 10.13.3 (Haswell Intell GPU) and most examples seems to work perfectly fine.

Building was really simple:

mkdir build
cd build
cmake ../.
make -j8

All it required was assimp, which was as simple as brew install assimp.

The linked stephane-lb/LearnOpenGL repo on the other hand doesn't even run cmake, as it's looking for X11, which it cannot find. Also that repo is 179 commits behind this one.

So I think you can say macOS is supported, with the above lines added to the readme.

I don't see any value in complicating things with Xcode projects, as this is an amazing resource to learning from / reading code, using your favourite text editor, and simply starting the examples from terminal.

[hyperknot]

I started going through all the examples.

Everything from chapers 1..4 is working perfectly, even the geometry shaders, except possibly 4.5.1 where the framebuffer is skewed, but it might be on purpose.

In chapter 5:

• 5.6 HDR: has the same strange skewed camera, moving is hard and changing the exposure is very very slow.
• 5.7 Bloom: turning ON and OFF doesn't make any difference.
• 5.8 Deferred Shading: lights are visible through the meshes
• 5.9 SSAO: is simply crazy, looks very glitchy.

I'll report as I find other issues.

[JoeyDeVries]

Thank you! I've updated the readme to reflect your instructions. It's good to hear most samples work straight out of the box; I can't fix them as I don't have a Mac to test them on. Thanks for the effort so far!

[hyperknot]

Thanks! I think I'll just post some screenshots here as a reference, this way other developers can also possibly fix them. Or maybe the bug is very obvious just by visual design.

// note: On the Readme, you made a typo in my name and I think people will obviously need cmake, glm glfw I think. These are all quite standard libs on brew, so the full install command should be like this:

brew install cmake assimp glm glfw
mkdir build
cd build
cmake ../.
make -j8

[hyperknot]

OK, here is the visual report of the problematic examples. I think (just an idea) what might be the bug in all of them is that 2x Retina / HiDPI resolution is not calculated right for framebuffers.

4.5.1 framebuffer skewing: https://youtu.be/lt7rZQnur6M

5.6 hdr skewing, super slow adjustments: https://youtu.be/aktRX3FicKk

5.7 bloom (no bloom difference for on/off): https://youtu.be/pXyF65cZRpk

5.8 deferred: lower left quarter for lights mixed with full screen scene: https://youtu.be/0IKmyZrgEy4

5.9 ssao glitch: https://youtu.be/diUZ-qJFby4

5.3 shadow examples in lower left quarter of the screen

Just if anyone happens to know how to fix these.

[JoeyDeVries]

This is great stuff, thank you! (and apologies for the typo, it's fixed now :)). Most of them appear to be related to the retina resolution not being taken into account (including the skewing); not sure about the heavy zoom, this might suggest that the GLM version for Mac OS X is still using degrees as its default angle unit? I'll leave the ticket open, thank you!

[hyperknot]

glm is definitely not using degrees, or otherwise all the examples would be broken as well :-)

[hyperknot]

OK, I just tested, using an open source tool RDM (https://github.com/avibrazil/RDM), if you set your screen to non-Retina resolution all the above mentioned examples work perfectly.

So right now, people can run the examples in non-Retina resolution, and in the future hopefully we can implement an easy fix.

(OK, in Bloom there is an issue with the color lights, but I guess that's probably an issue on other platforms as well).

[JoeyDeVries]

Sweeet, that's great to know; thanks for all the effort @hyperknot !

[rarest]

Using CMake client(3.11.0) to generate a Xcode project, when built, the binary file was outputted into the sub bin dir added Debug or Release as parent dir, not the same dir with shader resources, the binary file wouldn't find the shader resources.

For example: resource location: .../XcodeBuild/bin/1.getting_started/3.3.shader.fs binary location: .../XcodeBuild/bin/1.getting_started/Debug/1.getting_started__3.3.shaders_class

I pushed a pull request, please check. By the way, i am not familiar with CMake, maybe there are also better resolutions.

[dadidzf]

MacOS generate xcode project

cmake -G "Xcode" ../.

I think if you can add another choice (tips) as above in readme file, it will be helpful for user not familiar with cmake, just like me (don't know how to generate Xcode project)

Because what the "cmake ../. " generate, every time i modify and run, i need to the bin dir, and type "./1.getting_started__2.1.hello_triangle" , to start the window. i think the Xcode is more clearly.

Thanks

[chaiyujin]

@hyperknot @JoeyDeVries I replace (SCR_WIDTH, SCR_HEIGHT) with (BUF_WIDTH, BUF_HEIGHT) got by glfwGetFramebufferSize(winPtr, &BUF_WIDTH, &BUF_HEIGHT ) in frame buffer related functions glTexImage2D and glRenderbufferStorage.

It works fine for 9.ssao with retina. It might be a general solution for all screens.

[caochao]

how to generate Xcode project? I'm not familiar with cmake

[zinwalin]

how to generate Xcode project? I'm not familiar with cmake

mkdir build cd build cmake -GXcode ../