Snapshotting and effect handling for external entities are not handled correctly

Jofairden / EvenMoreModifiers

A mod for Terraria that adds a system for Modifiers that can apply to items giving various bonuses

https://zond.tech/emm/

Other

20 stars 10 forks source link

Snapshotting and effect handling for external entities are not handled correctly #29

Open Jofairden opened 5 years ago

Jofairden commented 5 years ago

The current snapshotting for modifiers is mediocre and buggy at best. A solution must be created for this problem

Scope:

Projectiles
NPCs
Projectiles shot by friendlies (minions)

Proposal

Proposed design: a snapshot of current active modifiers must be given to a particular entity (projectile, npc etc.) which can then be used in the appropriate hooks for effects. This will likely turn into boilerplate like ModifierItem.cs

Jofairden commented 5 years ago

TBD: Refactor ModifierEffect to ModifierPlayerEffect, add ModifierProjectileEffect and ModifierNpcEffect as new one.