JohK / nutsnbolts

A OpenSCAD library that allows for simple creation of nuts and bolts and respective nut catches and screw holes
GNU General Public License v3.0
267 stars 41 forks source link

Added a tiny overlap (epsilon) to subtractions #9

Closed qwazix closed 5 years ago

qwazix commented 5 years ago

so that OpenSCAD doesn't render artifacts in preview mode

So this, nutsboltshead-1 becomes this nutsboltshead

I have used your library in Rosalind, the new RepRap printer I'm building, and throughout that code I'm trying to make sure the preview does not have these "exact subtraction" artifacts. This is even more important for the assembly instructions as I need color rendering (i.e. can't use F6). You can still set e=0 to get the old behavior back.

I always believe it's better to just use upstream than keeping downstream forks so if you agree with the change I'd be glad if you could merge.

JohK commented 5 years ago

Thank you for the patch. I'm currently a bit slow to react, I'll try to answer faster next time.