JohN100x1 / IsekaiMod

An unbalanced gameplay mod for Pathfinder: Wrath of the Righteous
MIT License
19 stars 10 forks source link

[4.3.0] Bloodrager Legacy - No Bloodlines #129

Closed NightOwlByDay closed 1 year ago

NightOwlByDay commented 1 year ago

Describe the bug When trying to use the Bloodrager Legacy - Chimeric Rager, the list for selectable Bloodlines is empty. If the Mod TabletopTweaks-Base is used in conjunction with the TabletopTweaks-Core Mod, the "Aberrant" and "Destined" bloodlines (added by the "Base" Mod) become available for selection.

To Reproduce Steps to reproduce the behavior:

  1. Create Isekai character and select "Bloodrager Legacy - Chimeric Rager" as Legacy
  2. Continue character creation till Bloodline selection

Expected behavior At bloodline selection, all bloodrager bloodlines should be available.

Screenshots image

kjk001 commented 1 year ago

this is weird, for me the list is normal but I do believe you because I got a similiar report by someone claiming to have the same problem with the inquisitor domains, could you please:

  1. check if that list has similiar problems for you?
  2. Post me your player.log?

image

kjk001 commented 1 year ago

also, assuming you are affected by both problems, would you mind running a version of the mod with expanded debug messages for me to help me figure out what is causing it?

NightOwlByDay commented 1 year ago

Hi @kjk001, your hunch was correct, the list for domains is similarly empty when I try to create an isekai character with the Inquisitor Legacy - Domain Lord.

image

Player.log: Player.log

I'd be happy to help. How do I activate the expanded debug messages?

kjk001 commented 1 year ago

You can't on your own, I would have to create a specific build where I add a lot of checks and messages around the relevant sections of the code to try to figure out what is wrong.

Which would be an unofficial build not published or scanned on nexus, hence the question...

NightOwlByDay commented 1 year ago

Understood Still fine by me.

kjk001 commented 1 year ago

ok, the monk patch is finished, I will reset my git to the 4.3 release and write in some additional checks to figure out thisproblem at some point tommorow then upload the file here

kjk001 commented 1 year ago

IsekaiModDLLForLogging.zip so this is just a zip of the dll with some extended logging.

You will get a new line in the player.log: [IsekaiMod] Patching Bloodrager bloodlines

Ideally your next few lines after that should be: [IsekaiMod] Bloodrager Bloodline Selection initialized checking its various element lists [IsekaiMod] Features Reference Array Length= 24 [IsekaiMod] Features Elements Array Length= 0 [IsekaiMod] Features normal Array Length= 3 [IsekaiMod] Features all Array Length= 24 but you might also get a warning that the selection isn't initialized yet instead or different numbers for the various arrays, depending on what the lines are we should be able to tell at least a bit of the problem.

I uploaded just the dll because the rest of the files should be used from the official release...

NightOwlByDay commented 1 year ago

That was quick, thanks for taking the time to analyse an issue that seems rather isolated to me and apparently one other person :).

Player.log with TabletopsTweaks_Base disabled: Player.log

[IsekaiMod] Patching Bloodrager bloodlines [IsekaiMod] Bloodrager Bloodline Selection initialized checking its various element lists [IsekaiMod] Features Reference Array Length= 0 [IsekaiMod] Features Elements Array Length= 0 [IsekaiMod] Features normal Array Length= 0 [IsekaiMod] Features all Array Length= 21

Player.log with TabletopsTweaks_Base enabled: Player.log

[IsekaiMod] Patching Bloodrager bloodlines [IsekaiMod] Bloodrager Bloodline Selection initialized checking its various element lists [IsekaiMod] Features Reference Array Length= 2 [IsekaiMod] Features Elements Array Length= 0 [IsekaiMod] Features normal Array Length= 2 [IsekaiMod] Features all Array Length= 23

kjk001 commented 1 year ago

Well yes, it kept bugging me, adding some log messages doesn't take long, and my D&D game started a bit late...

Quick follow up question, do you play the enhanced edition or base edition?

I have an idea for the fix either way and will apply it for 5-0-0 but it would be nice to know if this is another somewhat dodgy place in the code in terms of stability of initialization or a place where the logic between editions simply differs...

NightOwlByDay commented 1 year ago

Great, looking foreward to 5.0.0 then :D! I play the with enhanced edition.

kjk001 commented 1 year ago

Then I have no idea why the reference array would not be initialized. Ah well, avoiding it from now on...