search

JohN100x1 / IsekaiMod

An unbalanced gameplay mod for Pathfinder: Wrath of the Righteous
MIT License
19 stars 10 forks source link

Sorcerer Chimera Legacy aren't copying spell into spellbook as you level up #140

Closed Lordjoseph7 closed 1 year ago

Lordjoseph7 commented 1 year ago

As the title states, I get them under the abilities list, but they do not appear in my spell book. Fey Bloodline.

JohN100x1 commented 1 year ago

It seems the handling of the AddKnownSpell component is not being hit.

edit: it looks like the asSpell.m_CharacterClass == referenceClass condition is false when it should be true.

edit2: it looks like using asSpell.m_CharacterClass.Equals(referenceClass) will work.

Lordjoseph7 commented 1 year ago

Sorry, I got confused and closed the issue. Glad you found the source of the problem.

JohN100x1 commented 1 year ago

@kjk001 Looks like there was a bug when comparing references (using .Equals is prefered over ==). You might want to check if there's any other logic which compares references.

I was able to add the fix in the new branch I created hotfix_5-0-X. Release for 5.0.3 should be later today.

kjk001 commented 1 year ago

yeah I just noticed the screw up on my part luckily for the most part checks required a contains rather than an equals anyway so few places should be affected