JohN100x1 / IsekaiMod

An unbalanced gameplay mod for Pathfinder: Wrath of the Righteous
MIT License
20 stars 10 forks source link

Weapons that use strength doesn't factor in Charisma replacement #155

Closed pikachu01 closed 1 year ago

pikachu01 commented 1 year ago

Describe the bug Weapons that uses strength for damage doesn't factor in Charisma in Isekai Archetypes that replaces Strength with Charisma for factoring in damage. Example: Composite Longbow/Shortbow/Throwing Axes.

To Reproduce Steps to reproduce the behavior:

  1. Use Composite Bow on a low strength Hero Archetype Isekai character
  2. See that the damage is low as it uses Strength rather than Charisma

Expected behavior Charisma should still replace Strength on a Composite Longbow weapon

Screenshots image

JohN100x1 commented 1 year ago

From what I can see, the composite enchantment and the Graceful Combat feature both uses the same OverrideDamageBonusStat method to override the weapon stat calculation, and that the composite enchnatment is also applied after the Graceful Combat feature, meaning only the composite enchnatment is effective.

Possible solutions:

I will investigate whether the 2nd solution is possible but if not I would rather let the weapon enchantments take priority.

NightOwlByDay commented 1 year ago

I'd like to add that I noticed the same behavior with the feature that lets you use Dexterity for damage from the Edge Lord Subclass. "Sonic Strike" was it's name, I think. On Composite LongBows, characters strength is used for Damage Calculations. On non Composite Longbows, dexterity was used for damage. I had just assumed it was intended bevavior, since the description for "Composite" Longbows defines, that a composite Longbow uses strength for additional damage. So I just used normal Longbows instead.

JohN100x1 commented 1 year ago

I think I will leave it as it is. I couldn't find a way to re-order the weapon stat calculation when multiple sources override the weapon stat.