search

JohN100x1 / IsekaiMod

An unbalanced gameplay mod for Pathfinder: Wrath of the Righteous
MIT License
19 stars 10 forks source link

Correction of the translation. #178

Closed Necht closed 12 months ago

Necht commented 1 year ago

Hi! I am now free and can devote a lot of time to help with the translation of your mod into russian. In this regard, I may have several questions about the meaning of certain words or actions. That's why I decided to create this topic where we could discuss it and where you, in case of introducing new skills, could write to me about it so that I would immediately translate. But first, can you please remind me how I can correct the current translation?

JohN100x1 commented 1 year ago

You can create a fork of this repository and then edit the LocalizationPack.json file. Once you finished making changes, you can create a pull request so I can merge into this repository.

Necht commented 1 year ago

Phew, it was harder than I expected.

I've done everything. This is a draft version of the translation, it needs additional edits, but it can already be added to the mod.

But to be honest, I don't quite understand how to create a pull reques. This is the first time I've done something like this on this site. Can you please explain?

In addition, when I tried to insert my translation into the localization file, it did not work and the "BROKEN_LocalizationPack" file was created. Did I do something wrong? How can I view and check my translation in the game? image

Necht commented 1 year ago

Also, while I was doing the translation, I noticed a little oddity. There were no lines in the localization file to translate the mod settings menu

image

image

image

Necht commented 1 year ago

And I have an idea about one ability:

Excalibur - сhange into a toggle ability

JohN100x1 commented 1 year ago

But to be honest, I don't quite understand how to create a pull reques. This is the first time I've done something like this on this site. Can you please explain?

  1. First install git.
  2. Next, create a fork of this repository here.
  3. Now open the terminal on your computer and enter git clone https://github.com/Necht/IsekaiMod.git.
  4. Replace the LocalizationPack.json with your edited version.
  5. In the terminal enter git add .
  6. Then git commit -m "feat: update russian in LocalizationPack.json"
  7. Then git push -u origin master
  8. You can create a new pull request here by clicking on the New pull request button.

In addition, when I tried to insert my translation into the localization file, it did not work and the "BROKEN_LocalizationPack" file was created. Did I do something wrong? How can I view and check my translation in the game?

You need to build the mod in order to check the translation in game. Replacing the LocalizationPack.json won't work.

  1. Install Visual Studio
  2. Open the IsekaiMod.sln using Visual Studio
  3. Make sure all dependencies are registered/installed.
  4. Now build the mod using Build -> Build Solution
  5. When the mod finishes building, you can check the translation in game.

Also, while I was doing the translation, I noticed a little oddity. There were no lines in the localization file to translate the mod settings menu

The settings menu doesn't use localized strings. It's hardcoded. The mechanism to change switch between localization in the game doesn't apply to the mod settings menu.

JohN100x1 commented 1 year ago

If it's easier then you can send me the LocalizationPack.json instead, and I can send you the updated IsekaiMod.zip file.

Necht commented 1 year ago

If it's easier then you can send me the LocalizationPack.json instead, and I can send you the updated IsekaiMod.zip file.

I tried to do this, but an error came out: image

So while I'm trying through Git...

Necht commented 1 year ago
  1. Replace the LocalizationPack.json with your edited version.

I have to do it in the mod folder, what is in the game files?

Necht commented 1 year ago

will it work out that way?

edited translation into Russian.txt

Necht commented 12 months ago

The settings menu doesn't use localized strings. It's hardcoded. The mechanism to change switch between localization in the game doesn't apply to the mod settings menu.

The new version of the Toy Box has a separate bar for switching the language in the settings menu. I haven't tried it, but maybe you can do something similar?

image

image

JohN100x1 commented 12 months ago

Ok I was able to build using your translation. There was some minor formatting issues, but otherwise it appears to be working. Here's a test build IsekaiMod-5-3-4-a.zip

Necht commented 12 months ago

Can you please check the Evil Legacy?

Everything is correct in the localization files, but in the game itself, the description of the evil legacy is replaced by the description of the Genius Legacy.

image image

Perhaps in the same way in English.

Necht commented 12 months ago

missing localization strings for kinetic knight

image

Necht commented 12 months ago

The translation is completely ready, only what I wrote earlier remains.

LocalizationPack.zip