search

JohN100x1 / IsekaiMod

An unbalanced gameplay mod for Pathfinder: Wrath of the Righteous
MIT License
19 stars 10 forks source link

AuraOfRighteousWrathEnchantment bug or feature, you decide #68

Closed kjk001 closed 1 year ago

kjk001 commented 1 year ago

AuraOfRighteousWrathEnchantment is applied twice on weapons that are both primary and secondary hand equips. I think only claws grown by an ability are affected, but still they get it twice :D

JohN100x1 commented 1 year ago

This is a bug. I don't think claws should get the effect applied twice.

kjk001 commented 1 year ago

it is because they count as both mainhand and offhand, for the offhand buff it should be possible to add a condition that says and not mainhand which would fix this

JohN100x1 commented 1 year ago

I noticed in your branch that in AuraOfRighteousWrathEnchantment, after replacing CreateWeaponEnchantment with CreateBlueprint<BlueprintWeaponEnchantment>, that bp.WeaponFxPrefab = new PrefabLink(); is missing. This might lead to bugs from my experience with null prefab fields in buffs.

kjk001 commented 1 year ago

Did you figure out the if condition here to prevent it from applying the buff to a secondary hand if it also a main hand?

JohN100x1 commented 1 year ago

I haven't been able to figure this out. I think I'll keep it as it is for now.

kjk001 commented 1 year ago

There doesn't seem to be a condtition allowing for an and not condition on the weapons type check.

bundillion commented 1 year ago

I've also occasionally had it roll the 5d6 like 40 times (5d6+5d6+5d6...) on a charge attack. Definitely a feature (except that it makes the game seize up for a moment) since it's only happened on allies and animal companions, and I have no idea how to reproduce it reliably. Might be involved with the Pounce ability, though.

JohN100x1 commented 1 year ago

Since I will be rewroking this feature, I will remove the effect on additional limbs.