Open eduardopietre opened 2 years ago
Hi,
I had a look at your contribution. Looks good at first glance!
Some suggestions:
Perhaps a way to scale the bolus/IOB y-axis could be introduced? When I view my kid's data in follower mode, his boluses/IOB only occupy roughly the lower 1/4 of the chart or less (bolus max 2,5 U, max IOB 5 U).
Having an easy way to identify negative IOB events would be great. I can not visually see a -0,27 U IOB event from the last 24 hours, but would love to see this easily. Perhaps colour IOB <0 in red or some other colour?
I am also unsure about what "Enable display" does. I only see the chart turn on/off with the "show on chart" setting. Should the current/historical (during scrolling) IOB value be displayed somewhere?
This looks great! Thanks! I was wondering if borrowing from loopkit would aid in implementing COB and predictions to get something like: https://github.com/LoopKit/Loop/blob/dev/Documentation/Screenshots/Phone%20Graphs.png
We should perhaps also free some screen real-estate to simply show a total IOB (and perhaps COB). Perhaps below the pie-chart is an option. Currently the text there mimics the days setting; so it's pretty much redundant. If IOB is enabled, showing the IOB there as a number may be a nice touch.
Just an idea. :)
Agreed. And perhaps move the pie chart to the far left, so it can sit close to the days setting.
Hi, Thanks for all the feedback! About the label / displaying the IOB value on screen, there are two TODOs annotations at RootViewController.swift: here and here. The logic to calculate these values is already on place, the only work missing is the user interface itself. However, I lack the UI experience and talent needed to create it.
Recently I have had close to no free time to code. COB would be a very nice addition, and could even reuse most of the plotting logic. Unfortunately, I'm not able to work on it right now. Feedback is appreciated, Thanks!
Insulin on Board implementation, all done locally. OpenAPS docs were used as reference for this implementation: https://openaps.readthedocs.io/en/latest/docs/While%20You%20Wait%20For%20Gear/understanding-insulin-on-board-calculations.html
This commit features:
Things to notice:
Sample screenshot: