nightscout HTTPS custom port is not consistently added to the URL using for REST API

JohanDegraeve / xdripswift

xdrip for iOS, written in Swift

GNU General Public License v3.0

327 stars 320 forks source link

nightscout HTTPS custom port is not consistently added to the URL using for REST API #400

Closed gjbadros closed 1 year ago

gjbadros commented 1 year ago

The requests coming from xdrip4ios for (at least) api/v1/entries/sgv.json and /api/v1/experiments/test are lacking the port number in the URL requested. I suggest a quick static analysis to investigate where the ":" and port number are missing. This causes it to break for a NS backend that runs on a non-standard (not 443) port.

xdripswift-missing-ns-port

paulplant commented 1 year ago

Yes - I noticed this last month. I've already fixed it on a local branch but I've got side-tracking into the Libre 2 NFC re-write.

I'll hopefully get around to pushing a fix for this in the next weeks.

paulplant commented 1 year ago

Fixed

nibbl84 commented 6 months ago

kind we can't connect xDrip4iOS to nightscout writes on the phone when we entered the link and API that - sll error occurred (although it was put on the server and the site is accessible via it). Can you tell me what I can do?