search

JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
317 stars 313 forks source link

iOS 17 support #455

Closed robinwo closed 10 months ago

robinwo commented 10 months ago

I upgraded to the iOS 17 public beta, and since then, I've been unable to open xDrip.

It crashes automatically on opening the app. I tried reinstalling the app (built from source) using Xcode 15 (beta) with target iOS 17.

More people who tested & having this same issue?

jonisaksson commented 10 months ago

I have been running iOS 17 since the first development beta (on version 7 i think now) without any problems at all with xdrip4iOS But whenever you install a beta you know that you run the risk that it will break something.

jonisaksson commented 10 months ago

By the way, i forgot. I did have some problems with building a new xdrip4iOS with the new Xcode beta, so I switched to Fastlane instead which worked a charm. Might be worth trying

ricardosllm commented 10 months ago

Are there any docs on using Fastlane? I looked it up in the fastlane dir, wiki here, and xdrip4ios.readthedocs.io but couldn't find it, would be happy to test it and even contribute to docs if needed.

paulplant commented 10 months ago

https://github.com/JohanDegraeve/xdripswift/blob/master/fastlane/testflight.md

LiroyvH commented 10 months ago

@robinwo Hi, I had the exact same problem. It was caused by a problem with AVAudioPlayer. For whatever weird reason, its not accepting some audio files (for some people, or some configurations don't attempt to play them (until an alarm is triggered (with specific parameters)) - including the sound played to keep xDrip awake in certain setups.

Re-encoding the audio files solved it for me so if needs be we'll just re-encode everything, though perhaps there's a better fix to work-around this with any audio file. Either way: hope we'll have time to get this fixed before the release on the 18th.

paulplant commented 10 months ago

OK, making this a priority for today

paulplant commented 10 months ago

Working on this with Liroy now. Only apps that are built and installed locally via Xcode seem to be affected by this issue.

It seems that Testflight and App Store releases (Shuggah) are unaffected by the AVAudioPlayer() issue related to .mp3 soundfiles.

The mp3 files are being reencoded to a compatible format by Liroy. Once we've finished, we'll push a quick update.

paulplant commented 10 months ago

Fixed by #459