search

JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
317 stars 313 forks source link

GH Action Validation Improvements and bump to Fastlane 2.215.0 #465

Closed dnzxy closed 9 months ago

dnzxy commented 9 months ago

This PR migrates validation improvements for the browser build from Loop / LoopFollow / LoopCaregiver to xDrip4iOS. These improvements are/were a community effort by @billybooth, @bjornoleh, and myself with heavy testing by @marionbarker.

A PR to port this over to iAPS is outstanding, see here. See the adjacent PRs for the mentioned repositories for detailed test logs and discussions:

Loop

LoopCaregiver

LoopFollow

This PR further bumps Fastlane to 2.215.0 which fixes a randomly occuring error Could not install WWDR certificate, see Loop PR 88.

bjornoleh commented 9 months ago

If you add Xcode 15 to the build workflow, this PR is probably more complete than mine.

dnzxy commented 9 months ago

@bjornoleh If you add Xcode 15 to the build workflow, this PR is probably more complete than mine.

Thank you for the hint, I missed that! Bumped Xcode to 15.0 also.

@paulplant builds fine, with added validation. See here for a successful build log.

paulplant commented 9 months ago

OK, looks good to me. Logs show a good build without errors (just a few warnings as always).

bjornoleh commented 9 months ago

Yes, I would recommend merging this. The other improvements are related to bringing better error messages for faulty secrets etc, to help setting this up correctly. And this brings in some of the latest improvements from Loop.

bjornoleh commented 9 months ago

Ideally, we should get full harmonisation with Loop, including the setup for an actions branch. Perhaps @dnzxy can bring in that as well, in this or a new PR?

dnzxy commented 9 months ago

Are you talking about the alive branch automation? Yes we could bring that in and harmonize it with Loop.

Depends on how pressing Paul feels a broken browser build for master is. The content of the PR as is brings in the validation improvements - that is what was migrated to LoopFollow and LoopCaregiver, too.

Loop and (soon hopefully) iAPS also have the improved automated build, that includes the auto-creation and check for the keepalice branch. Up to you, @paulplant.