JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
317 stars 313 forks source link

LibreLibreUp follower mode #473

Closed paulplant closed 7 months ago

paulplant commented 8 months ago

Will connect and pull the patient's CGM values using their LibreLinkUp account as a new data source follower option.

image

Will close #440

crsohr commented 8 months ago

Cool feature, though: is it something we want in the core of xdripswift?

Not sure their API is public, and not sure we have a “legal” binding to request data from LLU.

At the very least maybe we could add the hostname as a configurable option (without providing a default value) but still we might still infringe on their rights.

What are your thoughts about this?

paulplant commented 8 months ago

We considered this before working on it...

The reason we've been holding off for so long is to see the reaction to other apps using this method. So far, there has been no reaction at all.

We are not writing any data at all to the servers - this was something we've always respected to avoid problems.

I thought about obfuscating the API URLs, but they are already published in many different places and projects in the public realm without any issues.

paulplant commented 8 months ago

Also https://github.com/JohanDegraeve/xdripswift/pull/473/commits/60874af5fdedcf350c89120940fbe76776062b75 would close #460

paulplant commented 8 months ago

Background keep-alive can now be set to normal (as always), aggressive, or completely disabled.

When disabled, the app will not fire any alarms, updates, notifications or anything whilst in the background meaning battery usage will be almost zero.

Aggressive is the same as normal, but the "silent sound" is played every 2 seconds instead of every 5.

The user is fully informed (including changes to operation and battery impact) about this when changing these options.

Simulator Screenshot - iPhone 15 - 2023-11-13 at 13 18 28

Simulator Screenshot - iPhone 15 - 2023-11-13 at 13 18 44