JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
329 stars 330 forks source link

Sync the GitHub runner clock with the Windows time server #477

Closed bjornoleh closed 10 months ago

bjornoleh commented 10 months ago

Adding a step to workflow jobs that interface Apple servers, as a workaround for build issues caused by runner clocks being out of sync. See https://github.com/actions/runner issue number 2996 for details.

name: Sync clock run: sudo sntp -sS time.windows.com Added to the following workflows / jobs:

validate_secrets.yml / validate-fastlane-secrets add_identifiers.yml / identifiers build_xdrip.yml / build create_certs.yml / certificates

bjornoleh commented 10 months ago

This workaround is also being applied to iAPS and LoopFollow. It fixes a vast amount of build errors due to GitHub runner issues with the machine time it is booted with. Syncing to the Windows time server fixes the issue. There is an ongoing effort to fix things on the GitHub end, see the mentioned issue report at the runner repository. We don't know how soon this might be fixed. For LF and iAPS, we decided its not worth waiting, since the fix is trivial and harmless.

@paulplant @JohanDegraeve

paulplant commented 10 months ago

@JohanDegraeve - I think this can be merged directly (and then pushed to master) without waiting for any of the other changes that are waiting for dev. All changed files are external to the actual project code so no merge conflict risk. No version changes are needed.

bjornoleh commented 10 months ago

Thanks, for your convenience, here is a PR to master https://github.com/JohanDegraeve/xdripswift/pull/478

paulplant commented 10 months ago

Thanks, but everything must first be merged into dev... you can close the new one that goes directly to master 🙏

bjornoleh commented 10 months ago

Thanks, but everything must first be merged into dev... you can close the new one that goes directly to master 🙏

Thanks, yes I saw the branch protection rule popping up 😅