JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
316 stars 310 forks source link

Add settings to customize the progress bar #507

Open callms opened 3 months ago

callms commented 3 months ago

Add settings to:

Reverse how the progress bar fills

xdripswift 5.0 added a new progress bar at the bottom of the home screen to show how much time the sensor will still be active. By default, the progress bar “fills” up to the last day, this is opposite to how some apps (FL/FL2/FL3) work which might confuse users. Also for some reasons I find it more intuitive that the progress bar “empties”, like a battery indicator, and becomes “exhausted” when the sensor ends.

before after
IMG_7156 IMG_7155

Opt-out to the progress animation

When switching betweentabs, by defaults, the progress bar animates from zero. This PR adds a toggle to opt-out.

Settings Screen

Here is a screen showing how the settings screen shows with these two options:

IMG_7157

paulplant commented 1 month ago

Hi @callms , I was looking at this. I don't think we need to copy how Abbott do the sensor countdown for any real reason, but I can understand how some people might prefer to "count down" available sensor instead of "use up" the remaining sensor. The only thing for me was that it could be very confusing which option the user was using. Adding the text change to the used vs remaining in the later commit I think fixes this concern...

But, I'm not sure that adding an opt-out of the animation really adds much value. We've been actively reducing Settings options and will continue to hide/remove low-value settings over the next months.

I can see how the "count down" setting works and is needed, but I don't think we can justify an "no animation" setting.

Do you agree? Also the settings have changed a lot since you wrote the PR so we'd need to adjust things to fit.