search

JohanDegraeve / xdripswift

xdrip for iOS, written in Swift
GNU General Public License v3.0
329 stars 328 forks source link

downsample data if needed before sending it to live activity #517

Closed stami closed 6 months ago

stami commented 6 months ago

Another take on #513

See the discussion there.

paulplant commented 6 months ago

This looks really nice. And there is a big advantage to keeping the full dataset if it can stay under the payload limit.

The only thing I think should be changed is the variable naming convention so that it matches the rest of the project. The underscore for private/internal vars is not used anywhere in the project. (in fact I've never seen anybody use it in Swift before)...

Do you think you could update them to standard camel-case variable names?

I'll also pull the commit and test it myself using 5 minute readings to make 100% sure before merging although as you're not fundamentally changing anything, it should be fine.

Nice job 👏

paulplant commented 6 months ago

I'll merge it into a test branch. You can PR any new commits there and then when it's all ready and tested, we'll squash it into develop.