JohanFalt / Foundry_WoD20

World of Darkness 20th ed for Foundry VTT
GNU General Public License v3.0
27 stars 22 forks source link

Enabling Specialty to an attribute roll re-applies existing 'Add bonus' modifiers again #798

Closed JohanFalt closed 3 months ago

JohanFalt commented 5 months ago

Replicate the bug by making a new merit in the Notes tab then use "Add Bonus" on the new merit to give a -2 difficulty modifier to any attribute(Perception in this case), then click the checkmark to apply the newly created merit to the sheet.

Go to the main sheet tab and click Perception. It will be at -2 difficulty because of our new merit. Click the specialty checkmark, Perception will now be at -4 difficulty modifier erroneously. Further checking/unchecking the specialty button keeps adding more -2 modifiers until it hits the cap.

This is an issue because you can't use merit 'Add Bonus' Attribute difficulty modifiers and apply Specialty to the roll at the same time in a proper way, since it will always apply the modifier twice if you check for Specialty.

For some reason the bug doesn't happen when used in a Skill+Attribute+Specialty pool, only when it's Attribute+Specialty alone

JohanFalt commented 5 months ago

For some reason the bug doesn't happen when used in a Skill+Attribute+Specialty pool, only when it's Attribute+Specialty alone