search

JohanLarsson / KillWpfDesigner

A Visual Studio extension for killing the Wpf designer processes. All instances of XDesProc.exe
MIT License
16 stars 3 forks source link

Visual Studio 2019 support #3

Closed JVimes closed 5 years ago

JVimes commented 5 years ago

The extension isn't listed in the marketplace when using Visual Studio 2019 Preview. The final release date is in just over a month, so figured I'd request 2019 support. This might help, How to upgrade extensions to support Visual Studio 2019. Thanks!

JohanLarsson commented 5 years ago

Do you feel like writing a PR with this? I never bothered with installing the VS2019 preview.

JVimes commented 5 years ago

I had to target at least .NET 4.6 to get it to build. Then I tweaked the .vsixmanifest per the article, and it would run in the debugger, but didn't kill xdesproc, and there was a warning about the extension using deprecated APIs. The "next steps" section of that article mentions migrating to AsyncPackage, and I notice the extension uses non-async Package. That's all the time I have for it right now, unfortunately.

JohanLarsson commented 5 years ago

Ok, I'll have a look then, thanks for the effort!

JohanLarsson commented 5 years ago

Published version 1.1.0 now, hope it works. Please report back if it works on VS2019. I did not convert to async package, don't think this small extension adds much to load times. Did not feel like tool fighting any more :)

JVimes commented 5 years ago

Thank you much. It has the deprecated API warning, but it works.

JohanLarsson commented 5 years ago

Published v 1.1.1 Not sure it works for < VS2017 now.

JVimes commented 5 years ago

Works on my machine. Thanks! :)