search

JohanObrink / rethink-migrate

A migration tool for rethink db
MIT License
47 stars 24 forks source link

fix getCompletedMigrations(): return the expected list of migrations #17

Closed jeffreywescott closed 8 years ago

jeffreywescott commented 8 years ago

There seemed to be a bug in getCompletedMigrations() such that it was returning another promise rather than the expected list of migrations. This PR should fix that.

JohanObrink commented 8 years ago

I could not reproduce any error resulting from this (the tests ran fine for the rethinkdb driver). But in the name of symetry, I added toArray to the promise anyway. It's in https://github.com/JohanObrink/rethink-migrate/commit/1ccaf243ea87f98b26931e7e5bc4f4f7772444a7

The reason I use the toArray function instead of cursor.toArray() is in order to support rethinkdbdash with auto cursor toArray.

.then(function (result) { return result; })

...doesn't do anything so that part I skipped.

The change has been released as v 1.2.1