search

JohanObrink / rethink-migrate

A migration tool for rethink db
MIT License
47 stars 24 forks source link

Lint issues and test script #35

Closed vinicius0026 closed 7 years ago

vinicius0026 commented 7 years ago

Hi there.

First of all, thanks to putting your effort into building open source modules!

I'm starting a project with rethinkdb and I think your module will be of great help. But I've seen that it has been stale for a while.

This PR just solve some issues with linter and adds the default npm test script. But I have more things in mind, if you want help advancing this lib.

Well, I'll let you analyse this PR before submitting new things.

jordanh commented 7 years ago

Hi @vinicius0026, we're actively maintaining a fork. If you'd submit this pull, we'd gladly accept it.

vinicius0026 commented 7 years ago

Hi @jordanh Since there was no answer whatsoever here, I created a new version of this tool. As I wanted to update and organize code, I rewrote it from scratch, but it already is at feature parity with the original module.

If you are interested, we could put some joint effort into merging your fork with my re-implementation, so that there is one maintained lib for rethink migrations. What do you think?

jordanh commented 7 years ago

I like one over two versions for sure – I remember trying your new fork while you were in the middle of making the transition. I had some difficulty getting it to work on [our codebase].

Would you like to fork our code and give yours a shot again? If it works, we'll switch over!

vinicius0026 commented 7 years ago

@jordanh I'm not sure I fully understood your last paragraph. But please be welcome to take another look at rethinkdb-migrate. By now some bugs have been fixed, documentation has improved and there is another active collaborator, besides myself. Your collaboration would be much appreciated.

JohanObrink commented 7 years ago

@vinicius0026 Thanks for the PR. Sorry I haven't been active for a while - to much work :( If you are interested, I can add you as a contributor. I could really need some help. I also asked @jordanh If he wants to merge the fork back in.